-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/65 add zero-address checks #6
Conversation
The following issue is also related: code-423n4/2021-06-pooltogether-findings#81 |
contracts/BadgerYieldSource.sol
Outdated
require(address(badgerSettAddr) != address(0), "BadgerYieldSource/badgerSettAddr-not-zero"); | ||
require(address(badgerAddr) != address(0), "BadgerYieldSource/badgerAddr-not-zero"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the isContract
function from Open Zeppelin to check the addresses: https://docs.openzeppelin.com/contracts/2.x/api/utils#Address-isContract-address-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of gas $$$ for that. I don't think it's necessary.
Pull Request Test Coverage Report for Build 994697233
💛 - Coveralls |
code-423n4/2021-06-pooltogether-findings#65